fix: Handle unhandled promise rejection in stylesheet loading#35414
fix: Handle unhandled promise rejection in stylesheet loading#35414Lihexs wants to merge 4 commits intofacebook:mainfrom
Conversation
|
Hi @Lihexs! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Fix UnhandledPromiseRejection crash in Jest when CSS stylesheet resources fail to load.
When a stylesheet fails to load, the Promise created with
link.onerror = rejectwas not being caught, causing Node.js/Jest to crash with UnhandledPromiseRejection.
Changes:
.catch(() => {})to stylesheet loading Promises inReactFiberConfigDOM.js(3 locations)ReactDOMFloat-test.jsto match actual event dispatch orderNote: The empty
.catch()handler is intentional - React already tracks the error state viastate.loading |= Errored, so the catch is only needed to prevent Node.js from crashing on unhandled rejection.How did you test this change?
Unskipped and ran the previously failing test:
Before fix: Jest crashes with
UnhandledPromiseRejectionAfter fix: Test passes successfully